Build output files overwritten by Terser Plugin if comments extract enabled

[njugray]

beidou/packages/beidou-webpack/config/config.default.js

Line 15 in 21c1f66

filename: '[name].js?[hash]',

If comments extract enabled，comments will be extracted to separated files with suffix . LICENSE 。

With the default configuration of Beidou, which will leads to [name].js?[hash].LICENSE, reference to the same file, may cause source files overwritten by LICENSE files.

[justquanyin]

这个问题遇到过，开始的考虑是保留LICENSE的文件输出，但用户可以选择上传的文件中过滤掉LICENSE，既然有争议，可以去掉这个配置
https://github.com/alibaba/beidou/blob/master/packages/beidou-webpack/config/webpack/webpack.browser.js#L70
我默认去掉吧

[ahungrynoob]

[name]-[hash].js可以吗

[njugray]

[name]-[hash].js 的形式，文件不好引用

[ahungrynoob]

@njugray

module.exports = {
  assetWithHash(asset) {
    // 读取配置中的manifest
    const manifest = this.app.config.manifest || {};
    // 映射文件名
    let filename = asset;
    if (manifest[asset]) {
      filename = manifest[asset];
      return filename;
    }
    return this.helper.asset(filename);
  },
};

感觉利用ManifestPlugin

const ManifestPlugin = require('webpack-manifest-plugin');
factory.addPlugin(ManifestPlugin, { fileName: '../manifest.json' }, 'WebpackManifestPlugin');

顺便解决 #55

[njugray]

@ahungrynoob 这个可以作为新feature开发，当前这是个bug，先默认关闭 extractComments 修复掉

[ahungrynoob]

哦哦