Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dragonwell PR lacks various checking #11

Closed
luchsh opened this issue Feb 14, 2020 · 0 comments
Closed

[Bug] Dragonwell PR lacks various checking #11

luchsh opened this issue Feb 14, 2020 · 0 comments
Assignees
@luchsh

Comments

@luchsh
Copy link
Contributor

luchsh commented Feb 14, 2020

Description
Currently Dragonwell PR lacks following checks:

  • Comment format, we have defined it in .github/COMMIT_MESSAGE_TEMPLATE, but just enforce it by code review.
  • Patch format, such as trailing spaces, etc.;
  • Build, sanity test of the patch, we need this at PR level.

Steps to Reproduce
as stated above

Expected behavior
A PR can be merged only if it passes all the checks.

JDK version
11.0.5.1

Execution environment

  • OS and version: Linux
  • CPU model: x64
  • Number of CPU cores:
  • Size of physical memory:
  • Inside Linux container?
    • Linux container name (docker, pouch, etc):
    • Linux container version:
@luchsh luchsh self-assigned this Feb 14, 2020
This was referenced Feb 15, 2020
Merged
Closed
@luchsh luchsh assigned yuleil and unassigned yuleil Feb 21, 2020
luchsh added a commit that referenced this issue Feb 25, 2020
@luchsh
[Misc] Added workflow to check each pull request
26efcab 
Summary: Added following checks:
- Commit format checking, using dragonwell-releng/check_commit_action@master.
- Build and run sanity test in release and slowdebug mode.

Test Plan: checks shipped with this PR

Reviewed-by: yuleil, kuaiwei

Issue: #11
@luchsh luchsh closed this as completed Mar 10, 2020
@a11enhuang a11enhuang mentioned this issue Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luchsh luchsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luchsh @yuleil