New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbtype参数枚举化之后，equals方法没改全(druid1.2.1) #4005

Closed

lizongbo opened this issue Oct 27, 2020 · 0 comments

Assignees

Labels

Bug

Milestone

Collaborator

lizongbo commented Oct 27, 2020

https://github.com/alibaba/druid/blob/master/src/main/java/com/alibaba/druid/pool/DruidAbstractDataSource.java
第869行
` public void setValidationQueryTimeout(int validationQueryTimeout) {
if (validationQueryTimeout < 0 && JdbcConstants.SQL_SERVER.equals(dbTypeName)) {
LOG.error("validationQueryTimeout should be >= 0");
}
this.validationQueryTimeout = validationQueryTimeout;
}

`
c此时JdbcConstants.SQL_SERVER是个枚举，dbTypeName是字符串类型。
导入druid 1.2.1的源代码，sonarlint扫描提示：
Silly equality checks should not be made (java:S2159)

wenshao added this to the 1.2.2 milestone

wenshao added the Bug label

wenshao self-assigned this

wenshao closed this as completed in

10f84b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment