Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About sending renew request to eureka server #569

Closed
1 task
VainEffort opened this issue Mar 11, 2019 · 2 comments · Fixed by #571
Closed
1 task

About sending renew request to eureka server #569

VainEffort opened this issue Mar 11, 2019 · 2 comments · Fixed by #571
Assignees

Comments

@VainEffort
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

Method "fescar-discovery: EurekaRegistryServiceImpl-getInstanceId()" builds the instanceId with pattern "%s/%s:%d" (appName, ipaddress, port).
Eureka client(DiscoveryClient-renew()) sends renew request to the url: myConfigEurekServerAddress/eureka/apps//

There is a "/" in instanceId, so the eureka client cannot succeed to renew.

Ⅱ. Describe what happened

If there is an exception, please attach the exception trace:

Just paste your stack trace here!

Ⅲ. Describe what you expected to happen

renew success.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

  1. xxx
  2. xxx
  3. xxx

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • JDK version :
  • OS :
  • Others: my eurke server version is 1.6.2
@slievrly slievrly self-assigned this Mar 11, 2019
@slievrly
Copy link
Member

@sunrui849

@sunrui849
Copy link
Contributor

i see the renew method, you are true,i will change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants