Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iOS 相关改进 #400

Merged

Conversation

zymxxxs
Copy link
Contributor

@zymxxxs zymxxxs commented Nov 7, 2019

本 PR 做了什么?

  • webview 增加 loading 的功能,同时解决 present (fromBottom) 视图,动画不正常的问题
    • webview 没有loading,表现不友好,所以直接使用了 hidden 属性,同时也把动画不正常的问题解决了。
  • 修复 ‘关于手册页面’,GitHub 按钮遮挡状态栏的问题
    • SafeArea 就是 MediaQuery 减去 padding 的大小,所以,该地方直接使用 padding

截图

before

after

1. webview 增加 loading 的功能,同时解决 present 试图,动画不正确的问题
2. 修复 ‘关于手册页面’,GitHub 按钮遮挡状态栏的问题

Signed-off-by: cangzhu <cangzhu@wacai.com>
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2019

CLA assistant check
All committers have signed the CLA.

@hanxu317317
Copy link
Collaborator

LGTM

@hanxu317317 hanxu317317 merged commit 8b1cb88 into alibaba:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants