perf(core): improve form change trigger performance (#3236)

alibaba · Jun 28, 2022 · 8e8a661 · 8e8a661
1 parent 8c90617
commit 8e8a661
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/core/src/shared/internals.ts b/packages/core/src/shared/internals.ts
@@ -710,14 +710,13 @@ export const triggerFormInitialValuesChange = (
   form: Form,
   change: DataChange
 ) => {
-  const path = change.path
   if (Array.isArray(change.object) && change.key === 'length') return
   if (
     contains(form.initialValues, change.object) ||
     form.initialValues === change.value
   ) {
     if (change.type === 'add' || change.type === 'set') {
-      patchFormValues(form, path.slice(1), change.value)
+      patchFormValues(form, change.path.slice(1), change.value)
     }
     if (form.initialized) {
       form.notify(LifeCycleTypes.ON_FORM_INITIAL_VALUES_CHANGE)

diff --git a/packages/reactive/src/tree.ts b/packages/reactive/src/tree.ts
@@ -1,19 +1,23 @@
 import { RawNode, ProxyRaw } from './environment'
-import { ObservablePath, PropertyKey, IOperation } from './types'
+import { PropertyKey, IOperation } from './types'
 export class DataChange {
-  path: ObservablePath
+  node: DataNode
   key: PropertyKey
   object: object
   type: string
   value: any
   oldValue: any
   constructor(operation: IOperation, node: DataNode) {
+    this.node = node
     this.key = operation.key
     this.type = operation.type
     this.object = operation.target
     this.value = operation.value
     this.oldValue = operation.oldValue
-    this.path = node.path.concat(operation.key)
+  }
+
+  get path() {
+    return this.node.path.concat(this.key)
   }
 }
 export class DataNode {