Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

希望freeline可以增加参数使得不影响正常的debug编译 #13

Closed
zzz40500 opened this issue Aug 23, 2016 · 3 comments
Closed

希望freeline可以增加参数使得不影响正常的debug编译 #13

zzz40500 opened this issue Aug 23, 2016 · 3 comments
Labels
enhancement

Comments

@zzz40500
Copy link
Contributor

当使用as直接run的时候 freeline 不会对我的生成物有影响, 只有使用python 命令的时候才会对我的生成物有影响，因为有时候用户的环境是比较复杂的，当出现一个bug 的时候， 他可以直接用run编译项目， 排除所有freeline 可能对项目的影响。而不需要编辑 build.gradle里面的内容。
@lomanyong lomanyong changed the title 建议 希望freeline可以增加参数使得不影响正常的debug编译 Aug 23, 2016
@charvenhe
Copy link
Member

感谢提议，我们尽快完善

@zzz40500
Copy link
Contributor Author

zzz40500 commented Sep 1, 2016

我的想法是在python 的执行 build_script 的时候携带一个参数freeline ， 如果gradle插件中获取这个属性为true 并且freeline 中的hack也为true，才会执行才会执行一系列动作。

@lomanyong
Copy link
Member

@zzz40500 恩，我review了一下代码，之前觉得可能影响不大， 不过还是插入了一些额外的assets文件。确实可以直接return掉，如果没有带参数的话。

期待你的pr~

@zzz40500 zzz40500 closed this as completed Sep 4, 2016
@WQLhub WQLhub mentioned this issue Oct 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zzz40500 @lomanyong @charvenhe