Using multi-repo manifests without address for review

[ratmice]

When dealing with e.g. manifest repositories e.g. here on github, where there is no address for review in the manifest,
you currently get ERROR: bad address for review ''. Its a bit difficult to add try and add remotes to the repo downloaded repositories from git repo sync.

It would be nice if there was a way to easily add remotes to all the repositories checked out,
It seems like perhaps if there was a --remote-manifest-url to git repo init

git repo upload --remote, gives the impression that it only works with --single repositories, (correct?)
--remote string use specific remote for upload (use with --single)

Is there a nice way to make --remote work with multiple repositories, and if not do you think adding something such as --remote-manifest-url would be a good way to do so?

[jiangxin]

When dealing with e.g. manifest repositories e.g. here on github, where there is no address for review in the manifest,
you currently get ERROR: bad address for review ''.

This is fixed in pull request #12.

git repo upload --remote, gives the impression that it only works with --single repositories, (correct?)
--remote string use specific remote for upload (use with --single)

This is because for single repository, there is no manifest file for it, and there maybe more remotes defined in .git/config. So it's necessary to add "--remote" support for single repository.

Is there a nice way to make --remote work with multiple repositories, and if not do you think adding something such as --remote-manifest-url would be a good way to do so?

For multiple repositories, we can define different remote in localt_manifests/*.xml. We used to raise an error for duplicate remote element, this pull request fixed it. We can override the remote element of the default manifest by provide a local manifest file with a duplicate remote element with 'override' attribute turned on.

See pull request #11.

[jiangxin]

I will add test cases tomorrow.

[ratmice]

Thank you, it sounds perfect. I'm still working on a system with the review protocol, so close when you think it is ready.

[jiangxin]

Thank you, it sounds perfect. I'm still working on a system with the review protocol, so close when you think it is ready.

Can this review protocol you mentioned work with git-repo? Would you like to add the name of your platform to "git-repo ready" list in a section of the README.md of this repo?

[ratmice]

Just trying to implement AGitFlow so yes, once I've got it working i'll send a PR for the README.md definitely.