Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be a plan to break down patch and contribute some patches to the upstream? #28

Open
spacewander opened this issue Nov 5, 2022 · 2 comments

Comments

@spacewander
Copy link
Contributor

Why you need it?

When I read the source, I found that Higress uses a single patch to record the change from the upstream projects.
Therefore, Higress now have some huge patch file (9000 lines+), which will make the maintenance very hard.

Some features require patching several projects. For example, to add sentinel support, both go-control-plane and istio are patched. If we can move the patch into upstream, we can avoid some patches.

How it could be?

Break down the patch into multiple ones according to their features.
If possible, we can contribute some patches back to the upstream.

Other related information

@johnlanni
Copy link
Collaborator

Great idea, we'll be doing this during upgrade work #8, and we'll do our best to get most of these changes accepted by the upstream's community.

@Xunzhuo
Copy link
Collaborator

Xunzhuo commented Nov 6, 2022

@spacewander I am +1 on this. We should reduce patches, otherwise it will be hard to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants