Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI 流程增加 linters 校验，如 goimports/gosec/gofmt/... (Add linters check for CI) #48

Closed
SpecialYang opened this issue Nov 10, 2022 · 3 comments
Closed

CI 流程增加 linters 校验，如 goimports/gosec/gofmt/... (Add linters check for CI) #48

SpecialYang opened this issue Nov 10, 2022 · 3 comments
Assignees
@Xunzhuo
Labels
area/ci level/normal
Milestone
0.6.0

Comments

@SpecialYang
Copy link
Collaborator

We should add code format tool and check the code style before merging pr.
@SpecialYang SpecialYang added help wanted Extra attention is needed area/tools labels Nov 10, 2022
@johnlanni johnlanni changed the title Add lint-go format check CI 流程增加 linters 校验，如 goimports/gosec/gofmt/... (Add linters check for CI) Nov 30, 2022
@johnlanni johnlanni added this to the 0.6.0 milestone Nov 30, 2022
@xcbeyond
Copy link
Contributor

assign to me

@johnlanni johnlanni removed the help wanted Extra attention is needed label Dec 10, 2022
@johnlanni
Copy link
Collaborator

Already implemented in #126, thanks to @Xunzhuo

@Xunzhuo
Copy link
Collaborator

Xunzhuo commented Jan 18, 2023 •
edited

Part of #122

@DaCapoooo DaCapoooo mentioned this issue Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xunzhuo Xunzhuo

Labels
area/ci level/normal
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
4 participants
@xcbeyond @johnlanni @SpecialYang @Xunzhuo