Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Golang version of the existing CPP Wasm plugin: jwt-auth #591

Open
WeixinX opened this issue Oct 20, 2023 · 12 comments
Open

Comments

@WeixinX
Copy link
Collaborator

WeixinX commented Oct 20, 2023

No description provided.

@Ink-33
Copy link
Collaborator

Ink-33 commented Oct 20, 2023

#232 Sorry for the delay, I will finish it as soon as possible.

@WeixinX
Copy link
Collaborator Author

WeixinX commented Oct 20, 2023

@Ink-33 这个实现 #485 与现有的 CPP 版本不一致,麻烦区分下哈 ~

@Ink-33
Copy link
Collaborator

Ink-33 commented Oct 20, 2023

@Ink-33 这个实现 #485 与现有的 CPP 版本不一致,麻烦区分下哈 ~

意思是 #232 和这个 issue 需要实现的内容都需要跟wasm-cpp/extensions/jwt_auth保持一致对吧,看了一下 #485 是一个简单的 bearer token 认证但占用了jwt-auth这个名称,该咋处理

@johnlanni
Copy link
Collaborator

@Ink-33 那个插件改个名称,叫simple-jwt好了

@Ink-33
Copy link
Collaborator

Ink-33 commented Oct 20, 2023

@Ink-33 那个插件改个名称,叫simple-jwt好了

感觉叫simple-auth会不会更加有区分度😂

@CH3CHO
Copy link
Collaborator

CH3CHO commented Oct 20, 2023

@Ink-33 那个插件改个名称,叫simple-jwt好了

感觉叫simple-auth会不会更加有区分度😂

已经有了个 basic-auth 😂:https://github.com/alibaba/higress/blob/main/plugins/wasm-cpp/extensions/basic_auth

@johnlanni
Copy link
Collaborator

@Ink-33 那个插件改个名称,叫simple-jwt好了

感觉叫simple-auth会不会更加有区分度😂

这个插件只是简单集成了一个jwt的lib进来,或者可以叫simple-jwt-auth哈哈

@xianyouQ
Copy link

测试不能用啊,是我的问题吗?我看代码使用了encoding/json,tinygo不支持吧

@johnlanni
Copy link
Collaborator

@xianyouQ 你可以用官方cpp插件的jwt auth

@cf1998
Copy link
Contributor

cf1998 commented Dec 14, 2023

测试不了啊,是我的问题吗?我看代码用了encoding/json,tinygo不支持吧

已经支持了,可以参考一下这个官方文档 https://tinygo.org/docs/reference/lang-support/stdlib/
可以参考这篇文章验证测试:https://mp.weixin.qq.com/s/h8n1eNjgkpAqCoeXPsg_lw

@WeixinX
Copy link
Collaborator Author

WeixinX commented Dec 23, 2023

@Ink-33 请问这个 issue 是否有进展 ~

@Ink-33
Copy link
Collaborator

Ink-33 commented Dec 23, 2023

@Ink-33 请问这个 issue 是否有进展 ~

正在推进中,月底前可提出首版pr🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

6 participants