Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Http2Rpc won't become effective right away #617

Closed
CH3CHO opened this issue Nov 1, 2023 · 1 comment · Fixed by #657
Closed

Changes to Http2Rpc won't become effective right away #617

CH3CHO opened this issue Nov 1, 2023 · 1 comment · Fixed by #657
Assignees
@Hinsteny
Labels
area/dubbo level/easy priority/high type/bug Something isn't working

Comments

@CH3CHO
Copy link
Collaborator

CH3CHO commented Nov 1, 2023

Ⅰ. Issue Description

[AddOrUpdateHttp2Rpc](https://github.com/alibaba/higress/blob/main/pkg/ingress/config/ingress_config.go#L992) and [DeleteHttp2Rpc](https://github.com/alibaba/higress/blob/main/pkg/ingress/config/ingress_config.go#L1008C10-L1008C23) functions of IngressConfig won't trigger any MCP push, which causes creating, updating and deleting Http2Rpc resources won't become effective right away.

We should trigger corresponding MCP pushes when any changes are made to Http2Rpc resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hinsteny Hinsteny

Labels
area/dubbo level/easy priority/high type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug for when Http2Rpc been delete or addupdate need to push xds server Hinsteny/higress
3 participants
@CH3CHO @Hinsteny @johnlanni