Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e支持发送指定http协议的http请求 #730

Closed
sjcsjc123 opened this issue Dec 22, 2023 · 4 comments · Fixed by #822
Closed

e2e支持发送指定http协议的http请求 #730

sjcsjc123 opened this issue Dec 22, 2023 · 4 comments · Fixed by #822
Assignees
@spacewander
Labels
area/e2e good first issue Good for newcomers sig/ops

Comments

@sjcsjc123
Copy link
Collaborator

sjcsjc123 commented Dec 22, 2023 •
edited
Loading

目前e2e框架暂时不支持发送http2/http3的请求，需要添加支持一下。
@sjcsjc123 sjcsjc123 added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 24, 2024
@spacewander
Copy link
Contributor

我可以来做这件事。准备怎么指定 Protocol？在

higress/test/e2e/conformance/utils/http/http.go

Line 89 in 612c94d

type Request struct {
里面加个字段如何？

@sjcsjc123
Copy link
Collaborator Author

可以的

@johnlanni johnlanni removed the help wanted Extra attention is needed label Jan 30, 2024
@spacewander
Copy link
Contributor

spacewander commented Feb 3, 2024 •
edited
Loading

发现现在已经有 protocol 字段，不需要我加了。
另外 HTTP3 的支持需要 https://github.com/quic-go/quic-go ，而这个库要求 Go 1.21. Higress 目前是 Go 1.19，是先只支持 HTTP2，还是升级到 Go 1.21？

@sjcsjc123
Copy link
Collaborator Author

先只支持http2吧

@spacewander spacewander mentioned this issue Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacewander spacewander

Labels
area/e2e good first issue Good for newcomers sig/ops
Projects
Higress
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: allow specifying HTTP protocol mosn/higress
4 participants
@spacewander @johnlanni @sjcsjc123 @2456868764