You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you please update useUrlState to use react-router-dom instead of react-router please? here
This is both the recommended approach by the react-router package but also causing consumptions issues for micro frontends consuming useUrlState when under a shared react-router-dom instance.
I would have contributed this myself but I'm not keen on signing your Contributor License Agreement :) and this should also be an easy fix for you.
Thanks
The text was updated successfully, but these errors were encountered:
@brickspert in our case, we use ModuleFederation to share dependencies. and we are sharing and using react-router-dom.
Our remotes depend on our Router that is used from react-router-dom, but when they try to use this package, it fails for them since you use react-router and the internal context/state is not the same.
Hello @adguy360. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!
Hi Team,
Could you please update
useUrlState
to usereact-router-dom
instead ofreact-router
please? hereThis is both the recommended approach by the
react-router
package but also causing consumptions issues for micro frontends consuminguseUrlState
when under a sharedreact-router-dom
instance.I would have contributed this myself but I'm not keen on signing your Contributor License Agreement :) and this should also be an easy fix for you.
Thanks
The text was updated successfully, but these errors were encountered: