Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add environment support in config file and tag param #49

Closed
LaurenceLiZhixin opened this issue Jun 21, 2022 · 1 comment
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@LaurenceLiZhixin
Copy link
Collaborator

Add read from env support marked by ${ENV} for config and tag param

A read-from-env config file example is

autowire:
  normal:
    github.com/alibaba/ioc-golang/extension/normal/mysql.GORMDB:
      dev-mysql:
        param:
          host: ${MYSQL_DB_HOST}
          port: ${MYSQL_DB_PORT}
          username: ${MYSQL_DB_NAME}
          password: ${MYSQL_DB_PASSWORD}
          dbname: "dev"

A tag param config env injection example is

FestivalServiceClient api.ServiceIOCRPCClient `rpc-client:",address=${FESTIVAL_RPC_SERVICE_ADDRESS}"`
@LaurenceLiZhixin LaurenceLiZhixin added the good first issue Good for newcomers label Jun 21, 2022
@photowey
Copy link
Contributor

This issue has been implemented simply, see branch feature/issue49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants