Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

模块生命周期监听,添加spring mvc集成支持 #64

Closed
wants to merge 2 commits into from
Closed

模块生命周期监听,添加spring mvc集成支持 #64

wants to merge 2 commits into from

Conversation

liangruisen
Copy link

Support for #1.6.1.20180301 ,Fix #24 #30 #38 #57

添加spring mvc开发方式的支持
更新spring版本至4.2.0,只因spring mvc 4.2.0+版本才支持移除RequestMapping
添加spring mvc开发方式的支持
更新spring版本至4.2.0,只因spring mvc 4.2.0+版本才支持移除RequestMapping
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 111

  • 144 of 245 (58.78%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-13.0%) to 75.684%

Changes Missing Coverage Covered Lines Changed/Added Lines %
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/SpringModule.java 62 69 89.86%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/ModuleManagerImpl.java 82 107 76.64%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/SpringModuleRequestMappingHandlerMapping.java 0 69 0.0%
Totals Coverage Status
Change from base Build 97: -13.0%
Covered Lines: 470
Relevant Lines: 621

💛 - Coveralls

@JoeKerouac
Copy link
Contributor

请先完善一下单元测试(按照标准如何贡献代码进行),然后生命周期监听可以作为核心模块的功能,springMVC的支持建议作为一个单独的子模块来单独支持,参照1.7分支中的模块调用功能。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants