Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use MNN as a submodule/subproject? #13

Closed
daquexian opened this issue May 7, 2019 · 1 comment
Closed

How to use MNN as a submodule/subproject? #13

daquexian opened this issue May 7, 2019 · 1 comment

Comments

@daquexian
Copy link
Contributor

daquexian commented May 7, 2019

There is an MNN_DEPEND cmake variable, however, cmake variable is not visible to parent scope. So the super-project cannot get the correct MNN library path and compile flags.

The ideal solution is that the CMakeLists.txt of MNN adds a library target (named "mnn" or something else), and this target depends on vulkan, opengl and so on. So that users can simply depend on target "mnn" without concern about all the dependencies and compile flags.

What's more, I believe MNN should export a target (on make install or cmake -P cmake_install.cmake) as all modern cmake files do.

@li-qing
Copy link
Contributor

li-qing commented May 8, 2019

good suggestion. we will revise it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants