Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] Client async log. #10084

Closed
KomachiSion opened this issue Mar 13, 2023 · 0 comments · Fixed by #10085
Closed

[Enhance] Client async log. #10084

KomachiSion opened this issue Mar 13, 2023 · 0 comments · Fixed by #10085
Assignees
@KomachiSion
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Milestone
2.2.1

Comments

@KomachiSion
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Nacos client is supporting logback and log4j2 to print logs to specified files.

But now, the print log is using sync-appender which may cause some thread blocked by io hand.

Describe the solution you'd like
Change the sync-appender to async-appender
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Client Related to Nacos Client SDK labels Mar 13, 2023
@KomachiSion KomachiSion self-assigned this Mar 13, 2023
@KomachiSion KomachiSion added this to the 2.2.1 milestone Mar 13, 2023
@KomachiSion KomachiSion mentioned this issue Mar 13, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KomachiSion KomachiSion

Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.2.1
Development

Successfully merging a pull request may close this issue.

[ISSUE#10084] Use async appender to print log for nacos-client. KomachiSion/nacos
1 participant
@KomachiSion