Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于上传zip时候,type判断的bug #1966

Closed
inmapx opened this issue Oct 24, 2019 · 2 comments
Closed

关于上传zip时候,type判断的bug #1966

inmapx opened this issue Oct 24, 2019 · 2 comments
Milestone

Comments

@inmapx
Copy link

inmapx commented Oct 24, 2019

Issue Description

代码如下:
if (configInfo.getDataId().contains(SPOT)) {
String extName = configInfo.getDataId().substring(configInfo.getDataId().lastIndexOf(SPOT) + 1).toLowerCase();
try {
type = FileTypeEnum.valueOf(extName).getFileType();
} catch (Exception ex) {
type = FileTypeEnum.TEXT.getFileType();
}
}

Describe what happened (or what feature you want)

Describe what you expected to happen

至少应该toUpperCase一下吧,要不然type全部text类型了

type = FileTypeEnum.valueOf(extName.toUpperCase()).getFileType();

How to reproduce it (as minimally and precisely as possible)

上传zip配置包

Tell us your environment

Anything else we need to know?

小bug希望大佬们修复一下

@nkorange
Copy link
Collaborator

欢迎你贡献修复!

@inmapx
Copy link
Author

inmapx commented Oct 24, 2019

欢迎你贡献修复!

嗯嗯,好的,第一次加入开源项目,很荣幸,我先学习下怎么做。

@MistRay MistRay mentioned this issue Nov 15, 2019
5 tasks
@nkorange nkorange added this to the 1.2.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants