We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug 配置模块中DataSourcePoolProperties 类的ConnectionTimeout属性默认设置为30s,且提供了外部动态更改的代码处理。 但是在ExternalDataSourceProperties类中的build方法中覆盖了连接超时为3L ds.setConnectionTimeout(TimeUnit.SECONDS.toMillis(3L)); 会导致无法外部设置参数,在某些数据库响应变慢的时候,无法连接的情况。
Expected behavior 期待可以删除这个覆盖的链接超时参数,使用DataSourcePoolProperties中的配置
Actually behavior 出现3S覆盖的情况
Desktop (please complete the following information):
我是否可以提交一个PR,将这个默认的ds.setConnectionTimeout(TimeUnit.SECONDS.toMillis(3L));覆盖3S的代码删除掉
The text was updated successfully, but these errors were encountered:
我觉得可以, IdleTimeout应该也可以。
Sorry, something went wrong.
@shiyiyue1102 @realJackSun 确认一下。
可以删除
好的,我找时间,删除下并提交下PR,那么默认给他30S连接合适,还是保持3S连接超时比较好呢。
shiyiyue1102
realJackSun
Successfully merging a pull request may close this issue.
Describe the bug
配置模块中DataSourcePoolProperties 类的ConnectionTimeout属性默认设置为30s,且提供了外部动态更改的代码处理。
但是在ExternalDataSourceProperties类中的build方法中覆盖了连接超时为3L
ds.setConnectionTimeout(TimeUnit.SECONDS.toMillis(3L));
会导致无法外部设置参数,在某些数据库响应变慢的时候,无法连接的情况。
Expected behavior
期待可以删除这个覆盖的链接超时参数,使用DataSourcePoolProperties中的配置
Actually behavior
出现3S覆盖的情况
Desktop (please complete the following information):
我是否可以提交一个PR,将这个默认的ds.setConnectionTimeout(TimeUnit.SECONDS.toMillis(3L));覆盖3S的代码删除掉
The text was updated successfully, but these errors were encountered: