Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enhance grpc #9772

Closed
YunWZ opened this issue Dec 30, 2022 · 1 comment
Closed

[Feature] Enhance grpc #9772

YunWZ opened this issue Dec 30, 2022 · 1 comment
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@YunWZ
Copy link
Contributor

YunWZ commented Dec 30, 2022

Motivation

Now grpc-java supports more features, such as support for setting keep-alive time, keep-alive timeout, connection idle time, etc.

I think we should upgrade grpc to facilitate better use of grpc, such as closing connections in a graceful way (instead of using reflection).

Feature

  1. close the connection through grpc‘s API (instead of using reflection);
  2. Provide more configuration items to allow users to customize their grpc services to better optimize network performance.

What's change?

Server side:

  1. Close connection(Netty channel) by StreamObserver.onCompleted or StreamObserver.OnError. Of course, we need to set the maximum connection idle time of grpc。
  2. Provide more configuration items to allow users to customize their grpc services to better optimize network performance.

server side:
new properties and default values:

nacos.remote.server.grpc.sdk.max-inbound-message-size=10485760
nacos.remote.server.grpc.sdk.keep-alive-time=7200000
nacos.remote.server.grpc.sdk.keep-alive-timeout=20000
nacos.remote.server.grpc.sdk.permit-keep-alive-time=300000

nacos.remote.server.grpc.cluster.max-inbound-message-size=10485760
nacos.remote.server.grpc.cluster.keep-alive-time=7200000
nacos.remote.server.grpc.cluster.keep-alive-timeout=20000
nacos.remote.server.grpc.cluster.permit-keep-alive-time=300000

deprecated property:

nacos.remote.server.grpc.maxinbound.message.size

client side:
new properties and default values:

nacos.remote.client.grpc.channel.keep.alive.timeout=20000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants