Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

costa: install Node and Python packages in parallel #477

Merged
merged 4 commits into from Aug 20, 2020
Merged

costa: install Node and Python packages in parallel #477

merged 4 commits into from Aug 20, 2020

Conversation

FeelyChau
Copy link
Collaborator

@FeelyChau FeelyChau commented Aug 19, 2020 •
edited

Benchmark:
Test command:

$ time ./packages/cli/dist/bin/pipcook plugin install @pipcook/plugins-tensorflow-resnet-model-define --tuna

This plugin depends on tensorflow@2.2.0.

Branch Test A Test B Test C Test D AVG
master 1 m 20.06 s 1 m 19.86 s 1 m 25.03 s 1 m 18.33 s 1 m 20.82 s
modify/parallel-installation 1 m 11.06 s 1 m 04.47 s 1 m 04.92 s 1 m 11.27 s 1 m 07.93 s

In this typical scenario, reduced installation time by 15%.

@FeelyChau FeelyChau added the costa costa is the plugin management label Aug 19, 2020
yorkie
yorkie previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@yorkie yorkie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the results are reasonable because this PR merges the cost of installing node_modules into Python's, the former takes 20-30s approximately to be done :)

@yorkie
Copy link
Member

yorkie commented Aug 19, 2020

That would be that great if we add this benchmark script in this PR :)

@FeelyChau
Copy link
Collaborator Author

That would be that great if we add this benchmark script in this PR :)

Done.

@FeelyChau FeelyChau merged commit 3229df6 into master Aug 20, 2020
@FeelyChau FeelyChau deleted the modify/parallel-installation branch August 20, 2020 04:34
@yorkie yorkie mentioned this pull request Sep 4, 2020
Closed
21 tasks
gindis pushed a commit to gindis/pipcook that referenced this pull request Sep 11, 2020
@FeelyChau
costa: install Node and Python packages in parallel (alibaba#477)
8d6d989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorkie yorkie yorkie approved these changes

Assignees
No one assigned
Labels
costa costa is the plugin management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FeelyChau @yorkie