Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add the missing devices field when creating cri container #2209

Merged
merged 1 commit into from Sep 7, 2018

Conversation

YaoZengzeng
Copy link
Contributor

@YaoZengzeng YaoZengzeng commented Sep 6, 2018

Ⅰ. Describe what this PR did

As stated in the title.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
@codecov-io
Copy link

Codecov Report

Merging #2209 into master will decrease coverage by 0.2%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
- Coverage   64.97%   64.76%   -0.21%     
==========================================
  Files         208      208              
  Lines       16711    16727      +16     
==========================================
- Hits        10858    10834      -24     
- Misses       4507     4540      +33     
- Partials     1346     1353       +7
Flag Coverage Δ
#criv1alpha1test 32.96% <12.5%> (-0.08%) ⬇️
#criv1alpha2test 33.52% <12.5%> (-0.2%) ⬇️
#integrationtest 39.64% <0%> (-0.39%) ⬇️
#unittest 23.83% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 62.64% <25%> (-0.82%) ⬇️
cri/v1alpha1/cri.go 62.22% <25%> (-0.86%) ⬇️
daemon/containerio/hijack_conn.go 77.14% <0%> (-11.43%) ⬇️
daemon/containerio/options.go 84.12% <0%> (-4.77%) ⬇️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
pkg/meta/store.go 60.15% <0%> (-3.91%) ⬇️
daemon/mgr/container_utils.go 80.72% <0%> (-3.62%) ⬇️
daemon/containerio/container_io.go 74.58% <0%> (-1.11%) ⬇️
daemon/mgr/container.go 56.55% <0%> (-0.41%) ⬇️
... and 2 more

@allencloud
Copy link
Collaborator

There is no test case to cover device in kubernetes? @YaoZengzeng

@allencloud
Copy link
Collaborator

I am afraid we could add device testing in cri-tools. @YaoZengzeng @starnop

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Sep 7, 2018
@allencloud allencloud merged commit 4f73e55 into AliyunContainerService:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants