Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pull image before using it #2751

Merged
merged 1 commit into from Mar 15, 2019
Merged

test: pull image before using it #2751

merged 1 commit into from Mar 15, 2019

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Mar 15, 2019

Signed-off-by: Wei Fu fuweid89@gmail.com

Ⅰ. Describe what this PR did

The case maybe run by name. If we don't pull image before, the case will
fail. Each case should do their own setup job.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

CI

Ⅴ. Special notes for reviews

The case maybe run by name. If we don't pull image before, the case will
fail. Each case should do their own setup job.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid requested a review from rudyfly March 15, 2019 02:02
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0905abb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2751   +/-   ##
=========================================
  Coverage          ?   69.38%           
=========================================
  Files             ?      277           
  Lines             ?    17412           
  Branches          ?        0           
=========================================
  Hits              ?    12082           
  Misses            ?     4010           
  Partials          ?     1320
Flag Coverage Δ
#criv1alpha2_test 39.37% <ø> (?)
#integration_test_0 36.56% <ø> (?)
#integration_test_1 35.8% <ø> (?)
#integration_test_2 36.51% <ø> (?)
#integration_test_3 35.53% <ø> (?)
#node_e2e_test 35.29% <ø> (?)
#unittest 28.51% <ø> (?)

@rudyfly
Copy link
Collaborator

rudyfly commented Mar 15, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 15, 2019
@rudyfly rudyfly merged commit 1762bd0 into AliyunContainerService:master Mar 15, 2019
@fuweid fuweid deleted the me-update-test branch March 17, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants