support to set root dir of container log #2797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wang allen.wq@alipay.com
Ⅰ. Describe what this PR did
The PR allows user to set container log path by parameters log-opt. There are two ways to set container log path.
Start pouchd with --log-opt.
Or set it to pouch config file like this:
By this way, all new container will be applied this feature. The container log path will be
/tmp/daemon_log/<cid>/json.log
By this way, only the created container with "--log-opt root-key=/tmp/container_log" will be applied this feature. The container log path will be
/tmp/container_log/<cid>/json.log
.the second way has the high priority.
Ⅱ. Does this pull request fix one issue?
fix #2783.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add test.
Ⅳ. Describe how to verify it
by test.
Ⅴ. Special notes for reviews