Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3032 SeccompSecurity default path needs more consideration #3039

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

Novicei
Copy link
Collaborator

@Novicei Novicei commented Jul 21, 2022

Ⅰ. Describe what this PR did

When you use SeccompSecurity, SeccompProfilePath can come from multiple sources, and pouch does not do the bottom line for the default runtime. You can see the logic in k8s and containerd, and the modifications need to be bottom line.

Ⅱ. Does this pull request fix one issue?

3032

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

yes

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


“donghong” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Novicei Novicei requested review from cardyok and cxz66666 July 21, 2022 08:41
@Novicei Novicei merged commit 17f559f into AliyunContainerService:master Jul 21, 2022
@Novicei Novicei changed the title fix #3032 fix #3032 SeccompSecurity default path needs more consideration Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants