refactor: wrap the container's specs #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the container's specs, in the spec setup functions, it maybe need some daemon manager to get/set container information, so wrapping the containerManager/volumeManager/networkManager into the spec. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
=========================================
- Coverage 13.58% 13.5% -0.08%
=========================================
Files 65 65
Lines 3541 3561 +20
=========================================
Hits 481 481
- Misses 3010 3030 +20
Partials 50 50
Continue to review full report at Codecov.
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Describe what this PR did
Wrap the container's specs, in the spec setup functions, it maybe need
some daemon manager to get/set container information, so wrapping the
containerManager/volumeManager/networkManager into the spec.
2.Does this pull request fix one issue?
NONE
3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com