feature: implement exec and attach method of stream server #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 14.37% 14.12% -0.26%
==========================================
Files 117 118 +1
Lines 7103 7237 +134
==========================================
+ Hits 1021 1022 +1
- Misses 5995 6127 +132
- Partials 87 88 +1
Continue to review full report at Codecov.
|
|
@allencloud PTAL. |
YaoZengzeng
force-pushed
the
exec-attach
branch
from
9a4087a
to
23acbf1
Compare
YaoZengzeng
force-pushed
the
exec-attach
branch
from
23acbf1
to
394b8de
Compare
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
YaoZengzeng
force-pushed
the
exec-attach
branch
from
394b8de
to
9546080
Compare
|
LGTM |
pouchrobot
added
the
LGTM
YaoZengzeng
pushed a commit
to YaoZengzeng/pouch
that referenced
this pull request
Mar 16, 2018
…ttach feature: implement exec and attach method of stream server
YaoZengzeng
pushed a commit
to YaoZengzeng/pouch
that referenced
this pull request
Mar 16, 2018
…ttach feature: implement exec and attach method of stream server
YaoZengzeng
pushed a commit
to YaoZengzeng/pouch
that referenced
this pull request
Mar 16, 2018
…ttach feature: implement exec and attach method of stream server
YaoZengzeng
pushed a commit
to YaoZengzeng/pouch
that referenced
this pull request
Mar 16, 2018
…ttach feature: implement exec and attach method of stream server
YaoZengzeng
pushed a commit
to YaoZengzeng/pouch
that referenced
this pull request
Mar 16, 2018
…ttach feature: implement exec and attach method of stream server
YaoZengzeng
pushed a commit
to YaoZengzeng/pouch
that referenced
this pull request
Mar 16, 2018
…ttach feature: implement exec and attach method of stream server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Implement exec and attach method of stream server.
Add a new backend (streams) to the pouch IO to satisfy the need of stream server.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews