Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make pkg client independent to other inner pkgs #962

Merged
merged 1 commit into from Mar 28, 2018

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

We have discussed that we should make package pkg to be a very independent package which could let others to import directly.

To achieve this, I think we should make client package be a closure with no import other alibaba/pouch packages.

Currently I find that we import 3 packages:

  • github.com/alibaba/pouch/pkg/utils which uses TLSConfig;
  • github.com/pkg/errors which uses errors
  • github.com/alibaba/pouch/api/types which could be moved to package client in the future.

This PR only make the first and second package out of client package.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XL labels Mar 25, 2018
@allencloud allencloud force-pushed the rm-pkg branch 5 times, most recently from d8d3827 to cebaf93 Compare March 25, 2018 17:14
@codecov-io
Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #962 into master will increase coverage by <.01%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   12.94%   12.95%   +<.01%     
==========================================
  Files         123      122       -1     
  Lines        8314     8308       -6     
==========================================
  Hits         1076     1076              
+ Misses       7142     7136       -6     
  Partials       96       96
Impacted Files Coverage Δ
cli/cli.go 0% <ø> (ø) ⬆️
client/utils.go 0% <0%> (ø) ⬆️
client/client.go 11.11% <9.09%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9080b2f...8b23dc8. Read the comment docs.

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@allencloud
Copy link
Collaborator Author

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 28, 2018
@allencloud allencloud merged commit 6a76627 into AliyunContainerService:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants