Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add mock test for pouch package client #965

Merged
merged 1 commit into from Mar 28, 2018

Conversation

allencloud
Copy link
Collaborator

@allencloud allencloud commented Mar 25, 2018

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

For more reliable client package which could be a golang SDK for Pouch developer, we should add more guarantee work on this. This PR adds mock test for the client package.

In the code, we add a mock server in the client when unit testing.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@codecov-io
Copy link

Codecov Report

Merging #965 into master will increase coverage by 0.56%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #965      +/-   ##
=========================================
+ Coverage   12.94%   13.5%   +0.56%     
=========================================
  Files         123     124       +1     
  Lines        8314    8314              
=========================================
+ Hits         1076    1123      +47     
+ Misses       7142    7088      -54     
- Partials       96     103       +7
Impacted Files Coverage Δ
client/container.go 0% <ø> (ø) ⬆️
client/container_start.go 71.42% <71.42%> (ø)
client/request.go 46.34% <0%> (+46.34%) ⬆️
client/utils.go 50% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b5a8c...aaee138. Read the comment docs.

@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 28, 2018
@Letty5411 Letty5411 merged commit 4bd9948 into AliyunContainerService:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants