bugfix: support copy dest with file name #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakaZhou719
changed the title
fanux
reviewed
Apr 21, 2022
build/buildimage/utils.go
Outdated
| @@ -43,7 +43,7 @@ func initImageSpec(kubefile string) (*v1.Image, error) { | |||
|
|
|||
| rawImage := parser.NewParse().Parse(kubeFile) | |||
| if rawImage == nil { | |||
| return nil, fmt.Errorf("failed to parse kubefile, image is nil") | |||
| return nil, fmt.Errorf("failed to parse kubefile, bad Kubefile content") | |||
There was a problem hiding this comment.
Should tell user the error detail is "get rawImage failed", and the parse function should return error.
|
|
fanux
approved these changes
Apr 21, 2022
fanux
pushed a commit
to fanux/sealer
that referenced
this pull request
Apr 22, 2022
* bugfix:support copy dest with file name;not panic if decode line failed
fanux
pushed a commit
to fanux/sealer
that referenced
this pull request
Apr 22, 2022
* bugfix:support copy dest with file name;not panic if decode line failed
fanux
pushed a commit
to fanux/sealer
that referenced
this pull request
Apr 22, 2022
* bugfix:support copy dest with file name;not panic if decode line failed
bxy4543
pushed a commit
to bxy4543/sealer
that referenced
this pull request
Jun 27, 2022
* bugfix:support copy dest with file name;not panic if decode line failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
1, support copy dest with file name
2.not panic if decode line failed
Describe how to verify it
Special notes for reviews