Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provides logging component extension capabilities and Standardized log format #37

Closed
sczyh30 opened this issue Feb 12, 2020 · 0 comments · Fixed by #217
Closed

Provides logging component extension capabilities and Standardized log format #37

sczyh30 opened this issue Feb 12, 2020 · 0 comments · Fixed by #217
Assignees
@louyuting
Labels
area/logging Issue related to logging of Sentinel kind/enhancement Category issues or PRs related to enhancement
Projects
Sentinel Golang V1 (beta)
Milestone
1.0.0

Comments

@sczyh30
Copy link
Member

sczyh30 commented Feb 12, 2020 •
edited by louyuting

#Issue Description

Type: feature request

Describe what feature you want

Currently, logging module define the standard log interface (Logger and provide the capacity to extend this own logging component.

User could use other logging component, like Logrus and zap, to replace the default logging.

Besides, Sentinel should standardized log format. using log message + KV parameters to replace current implementation,
@sczyh30 sczyh30 added kind/enhancement Category issues or PRs related to enhancement area/logging Issue related to logging of Sentinel labels Feb 12, 2020
@louyuting louyuting changed the title Improve common logging Upgrade common logging framework Feb 13, 2020
@louyuting louyuting changed the title Upgrade common logging framework Replace the default common logging framework Feb 13, 2020
@louyuting louyuting changed the title Replace the default common logging framework Provides logging component extension capabilities and Standardized log format Aug 14, 2020
@louyuting louyuting modified the milestones: 1.0.0, 0.6.0 Aug 14, 2020
@louyuting louyuting linked a pull request Aug 31, 2020 that will close this issue
Structure logging to json #217
Merged
@sczyh30 sczyh30 modified the milestones: 0.6.0, 1.0.0 Sep 2, 2020
@louyuting louyuting modified the milestones: 1.0.0, 0.7.0 Sep 2, 2020
@louyuting louyuting self-assigned this Sep 3, 2020
@louyuting louyuting modified the milestones: 0.7.0, 0.6.1 Sep 7, 2020
@sczyh30 sczyh30 modified the milestones: 0.7.0, 1.0.0 Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louyuting louyuting

Labels
area/logging Issue related to logging of Sentinel kind/enhancement Category issues or PRs related to enhancement
Projects
No open projects
Sentinel Golang V1 (beta)
  
Awaiting triage
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Structure logging to json louyuting/sentinel-golang
2 participants
@louyuting @sczyh30