Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for common util #48

Closed
louyuting opened this issue Feb 17, 2020 · 2 comments · Fixed by #59
Closed

Add unit test for common util #48

louyuting opened this issue Feb 17, 2020 · 2 comments · Fixed by #59
Assignees
@zsy619
Labels
area/test Issue or PR related to test cases good first issue Good for newcomers

Comments

@louyuting
Copy link
Collaborator

Issue Description

Type: feature request
Add unit test for common util

Describe what feature you want

Code path: util/*
Target coverage: 50+% statements.

Additional context

Add any other context or screenshots about the feature request here.
@louyuting louyuting added good first issue Good for newcomers area/test Issue or PR related to test cases labels Feb 17, 2020
@zsy619
Copy link
Contributor

zsy619 commented Feb 23, 2020

好了，领取了

@louyuting
Copy link
Collaborator Author

Thanks for your contribution.
Discussion are welcomed.

@zsy619 zsy619 mentioned this issue Feb 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsy619 zsy619

Labels
area/test Issue or PR related to test cases good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit test for common util zsy619/sentinel-golang
2 participants
@zsy619 @louyuting