Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust governance module component naming discussion #3238

Closed
steverao opened this issue Mar 30, 2023 · 8 comments
Closed

Adjust governance module component naming discussion #3238

steverao opened this issue Mar 30, 2023 · 8 comments
Labels

Comments

@steverao
Copy link
Collaborator

steverao commented Mar 30, 2023

Background

The microservices governance capability built by the community was released in version 2.2.10-RC1. For related content, please refer to:

We named the relevant modules at that time:

  • Routing: spring-cloud-starter-alibaba-governance-routing
  • Security: spring-cloud-starter-alibaba-governance-auth

We did them according to following rule:
The Spring Cloud Alibaba community has been proposed and voted by the Community Steering Committee Management Committee. From 2023, the new module naming rules of the community will follow:
spring-cloud-starter-(component's company name)-(component name)-function name(subfunction name)
Name the module, where the content of () indicates that it is not necessary and can be omitted, and the sub-function name is at most one level.
But we will develop some new abilities in the future, such as mTLS, Outlier instance removal and so on, I think we need to contain them in our above module, because, if we create new module, relevant abilities will be very scattered, not concentrated. But inclusiveness of above module names is not high, generalization is not enough.

New Plan

I think following naming of relevant modules is more suitable.

  • Routing: spring-cloud-starter-alibaba-governance-traffic
  • Security: spring-cloud-starter-alibaba-governance-security

In the future, we can put mTLS and some other security abilities into spring-cloud-starter-alibaba-governance-security, and put Outlier instance removal and some other traffic management abilities into spring-cloud-starter-alibaba-governance-traffic.

@steverao steverao added the kind/discussion Mark as discussion issues/pr label Mar 31, 2023
@yuluo-yx
Copy link
Collaborator

I agree with you!

1 similar comment
@qakqs
Copy link

qakqs commented Mar 31, 2023

I agree with you!

@qakqs
Copy link

qakqs commented Mar 31, 2023

Can it be named according to the concept and specification of DDD?

@steverao
Copy link
Collaborator Author

steverao commented Apr 3, 2023

Can it be named according to the concept and specification of DDD?

Please explain your thinking and reason, it's hard to modify naming rule. Because, it was proposed and voted by the Community Steering Committee Management Committee.

@ruansheng8
Copy link
Collaborator

ruansheng8 commented Apr 6, 2023

Is there a plan to further decompose the traffic module into sub-modules, given that it encompasses multiple functionalities such as routing, rate limiting, circuit breaking, and retrying?

@steverao
Copy link
Collaborator Author

steverao commented Apr 6, 2023

Is there a plan to further decompose the traffic module into sub-modules, given that it encompasses multiple functionalities such as routing, rate limiting, circuit breaking, and retrying?

Rate limiting and circuit breaking will be contained in modules of Sentinel. Others that if we plan to develop will be contained in module of traffic directly.

Copy link

This issue has been open 30 days with no activity. This will be closed in 7 days.

@github-actions github-actions bot added the stale label Mar 10, 2024
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity.If you think this should still be open, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for your interest and contribution to the Sping Cloud Alibaba Community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants