Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests in alibaba-nacos-config are order-dependent flaky #3503

Closed
lxb007981 opened this issue Nov 22, 2023 · 2 comments
Closed

Some tests in alibaba-nacos-config are order-dependent flaky #3503

lxb007981 opened this issue Nov 22, 2023 · 2 comments
Labels

Comments

@lxb007981
Copy link

lxb007981 commented Nov 22, 2023

Which Component
spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-config

Describe the bug
Some tests in alibaba-nacos-config are order-dependent flaky. They can pass or fail under different tests running orders. Some tests are always failed when running individually. The detailed related tests list is linked in this pr.

Reason
The environments are not properly set up for every test.

Simplest demo
The URL of the simplest demo to reproduce the problem.

To Reproduce
Steps to reproduce the behavior:

  1. Build the module using ./mvnw clean install -DskipTests -pl spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-config -am
  2. Run a flaky test like ./mvnw -pl spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-config test -Dtest=com.alibaba.cloud.nacos.configdata.NacosConfigDataLocationResolverTest#testStartWithASlashIsOK
  3. See error
  4. If using a test order randomizer (or simply using @TestMethodOrder(OrderAnnotation.class) and @Order(1)), running the whole test class could also fail depending on the test execution order.

Expected behavior
All the tests should pass under any order, regardless of whether they are run individually or combined.

Screenshots
image

Additional context
Java version: 17.0.9
Maven version: 3.9.0

Copy link

This issue has been open 30 days with no activity. This will be closed in 7 days.

@github-actions github-actions bot added the stale label Dec 31, 2023
Copy link

github-actions bot commented Jan 8, 2024

This issue has been automatically marked as stale because it hasn't had any recent activity.If you think this should still be open, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for your interest and contribution to the Sping Cloud Alibaba Community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant