Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-unsafe may happen in spring-cloud-alibaba-nacos-config module. #652

Closed
wangzhanxu opened this issue May 19, 2019 · 2 comments · Fixed by #668
Closed

Thread-unsafe may happen in spring-cloud-alibaba-nacos-config module. #652

wangzhanxu opened this issue May 19, 2019 · 2 comments · Fixed by #668
Labels
area/nacos spring cloud alibaba nacos good first issue
Milestone
2.1.0.RELEASE

Comments

@wangzhanxu
Copy link

Nacos Config Module

DateFormat instance is not thread-safe in NacosRefreshHistory class.
@fangjian0423
Copy link
Contributor

Could you please help to contribute to modify it?

@fangjian0423 fangjian0423 added good first issue area/nacos spring cloud alibaba nacos labels May 20, 2019
@pyhblacksky pyhblacksky mentioned this issue May 24, 2019
Merged
@pyhblacksky
Copy link
Contributor

@fangjian0423 Hello, I solve it problem. Please check it. If there is any problem, please let me know in time

@fangjian0423 fangjian0423 added this to the 0.9.1.RELEASE milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/nacos spring cloud alibaba nacos good first issue
Projects
None yet
Milestone
2.1.0.RELEASE
Development

Successfully merging a pull request may close this issue.

fix thread-unsafe in NacosRefreshHistory pyhblacksky/spring-cloud-alibaba
3 participants
@fangjian0423 @wangzhanxu @pyhblacksky