-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentinelConverter不支持热点参数规则 #771
Comments
demo 中的热点规则,可以直接用
|
@pigxcloud 我的热点规则如下,无法使用。 [
{
"resource": "/shares/1",
"limitApp": "default",
"grade": 1,
"paramIdx": 1,
"count": 0.0,
"controlBehavior": 0,
"maxQueueingTimeMs": 0,
"burstCount": 0,
"durationInSec": 1,
"paramFlowItemList": [
{
"object": "1",
"count": 1,
"classType": "int"
}
],
"clusterMode": false,
"clusterConfig": {
"flowId": null,
"thresholdType": 0,
"fallbackToLocalWhenFail": true,
"sampleCount": 10,
"windowIntervalMs": 1000
}
}
] |
周老师 我测试了一下。如果直接用你上边JSON 是没有问题的 nacos 1.1.0
|
限流规则解析完会通过 |
热点参数 是这个 zz
热点参数这个 ParamFlowRuleUtil.validClusterRuleId |
I remove the check code in if there is some problems in |
不支持热点参数限流。
我写了个Sentinel Dashboard,使用Nacos持久化数据。安装包、使用说明在这里:https://github.com/eacdy/Sentinel-Dashboard-Nacos/releases
其他规则都能正常解析,唯独热点参数限流规则无法正常解析。感觉这是个BUG,请修正。
PS. SentinelConverter的代码两层try...catch...,代码可读性不佳,而且报的异常上去就ignore,里面什么都不打印,很不友好。我调试时,就是会进到ignore异常的。
是否应该改进下?
The text was updated successfully, but these errors were encountered: