-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
结合动态域名解析模块,在我们项目中测试发现了几个问题 // some problems in dyups #1778
Comments
这似乎是源码上讨论的问题,
这个逻辑是
所以这里不确定你遇到什么问题。这个逻辑如果不解锁反而异常 |
这里严谨的需要全部加锁。但是因为估计当初逻辑是再通用硬件上操作,默认原子操作cmp和inc。这里标记TODO估计也有考虑这个。 |
https://github.com/alibaba/tengine/blob/master/modules/ngx_http_upstream_check_module/ngx_http_upstream_check_module.c#L1239
|
是的,但是这里ref、owner 类型并不是ngx_atomic_t类型的,代码上多处有访问共享内存不加锁的情况 |
是的。这里需要一个fix。这里todo应该改掉fix |
todo位置,或者加锁不严谨 由此引入:9210e49b0 |
由于我们的项目需要支持动态增删节点且需要支持stream模块,故开发了新的模块 供大家参考
The text was updated successfully, but these errors were encountered: