Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph tracer #4

Closed
www516717402 opened this issue Nov 9, 2021 · 2 comments
Closed

graph tracer #4

www516717402 opened this issue Nov 9, 2021 · 2 comments
Labels
question Further information is requested

Comments

@www516717402
Copy link
Contributor

Why not use torch.FX module and no need a lot of manual work in latest version.
@peterjc123
Copy link
Collaborator

peterjc123 commented Nov 9, 2021 •
edited

Good question. There are two major reasons that we write our own graph tracer.

  1. When we wrote this code, torch.fx was not open source.
  2. Currently, torch.fx doesn't provide the details of the I/O tensors of the operators in the computation graph, thus cannot be used in our pruners.

Once torch.fx meets our needs, we can migrate to using it.

@peterjc123 peterjc123 added the question Further information is requested label Nov 9, 2021
@www516717402
Copy link
Contributor Author

@peterjc123 Great project. meanwhile Look forward update FX module to this repo.

@peterjc123 peterjc123 mentioned this issue Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterjc123 @www516717402