Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: memory leak if connection closed during handshake #197

Closed
Luffbee opened this issue Jun 27, 2022 · 1 comment · Fixed by #287
Closed

[Bug]: memory leak if connection closed during handshake #197

Luffbee opened this issue Jun 27, 2022 · 1 comment · Fixed by #287
Assignees
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🐞 bug Something isn't working

Comments

@Luffbee
Copy link

Luffbee commented Jun 27, 2022

What happened?

/* xqc_hs_buffer_t data buffer for crypto data from tls */
xqc_list_head_t initial_crypto_data_list;
xqc_list_head_t hsk_crypto_data_list;
xqc_list_head_t application_crypto_data_list;

These 3 lists are not cleared when connection destroy, so if the connection is closed during handshake (e.g. caused by a timeout), the xqc_hs_buffer_ts in these lists will leak.

Steps To Reproduce

I found this bug in a customized version, so I'm not sure this can be reproduced.

Relevant log output

No response

@ruiqizhou ruiqizhou added the 🐞 bug Something isn't working label Jun 27, 2022
@ruiqizhou ruiqizhou added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 2, 2022
@Kulsk
Copy link
Collaborator

Kulsk commented Jul 12, 2023

fixed on #287

@Kulsk Kulsk closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants