Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support streams #57

Closed
dkrieger opened this issue Nov 5, 2018 · 6 comments
Closed

[feature] support streams #57

dkrieger opened this issue Nov 5, 2018 · 6 comments

Comments

@dkrieger
Copy link

dkrieger commented Nov 5, 2018

Redis streams have been available in 5.0 release candidates for some time (correction: 5.0.0 has officially been released). antirez recently greatly expanded documentation on streams. github.com/go-redis/redis has full stream command support.

TL;DR: streams are upon us

Can stream support be added to the roadmap?

@alicebob
Copy link
Owner

alicebob commented Dec 5, 2018

I see no fundamental problem adding them, but it's quite a big topic.

How do you currently use them? Since implementing a basic version (maybe only XADD, XLEN, XRANGE?) is a lot more feasible.

@kathan24
Copy link

kathan24 commented Mar 26, 2020

First of all, this is an amazing library to use and perform testing. Thank you so much

I am looking for a XREAD functionality. I am using like
XREAD BLOCK 0 STREAMS mystream $ and XREAD BLOCK 0 STREAMS mystream ID

Any idea if XREAD could be implemented? If yes, when do you think it would land by?

@NefixEstrada
Copy link

What is the status of this issue? It seems that since 2.13.3 XREAD is supported, but it doesn't seem to work

@and-elf
Copy link

and-elf commented Apr 7, 2021

First of all, this is an amazing library to use and perform testing. Thank you so much

I am looking for a XREAD functionality. I am using like
XREAD BLOCK 0 STREAMS mystream $ and XREAD BLOCK 0 STREAMS mystream ID

Any idea if XREAD could be implemented? If yes, when do you think it would land by?

basic implementation works
I've been looking into blocking calls a bit.
It seems to me that the whole application design is aimed towards single execution, i.e there doesn't seem to be an easy fix to handle multiple commands at the same time from the same client (which is a requirement for blocking calls).
I've implemented a basic (and naïve) handling of blocking xread, but the mutex blocks concurrent calls.. maybe there is a way to fix this..

@alicebob
Copy link
Owner

I just added a PR for XREAD BLOCK: #209. Branch is xblock.

@alicebob
Copy link
Owner

I've also added block and noack support to xreadgroup (#210). It's merged in master. I think that should be it for streams! (except some xinfo subcommands. Let me know if anyone cares about those)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants