Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O2B-547] Update RUNS API request should check user permissions #561

Closed
graduta opened this issue Apr 22, 2022 · 0 comments
Closed

[O2B-547] Update RUNS API request should check user permissions #561

graduta opened this issue Apr 22, 2022 · 0 comments
Labels
backend

Comments

@graduta
Copy link
Member

graduta commented Apr 22, 2022

Currently there is no check on updating a run on back-end. There should be one that checks if the user is admin or not

Acceptance Criteria:

  • Similar to tags.controller, add a check for admin in the runs.controller for updating the RUN
  • Add tests to validate the new behaviour;
  • OpenAPI spec file should be updated accordingly;

e.g of a similar change to tags: https://github.com/AliceO2Group/Bookkeeping/pull/547/files#diff-dfce4d9d11a31be72739d767812e1b3435a06045c19be411a28b517d2c208001
@graduta graduta closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KoenLippe @graduta