Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requests library to take verify and cert parameters #51

Open
rkagin opened this issue May 4, 2020 · 7 comments
Open

Allow requests library to take verify and cert parameters #51

rkagin opened this issue May 4, 2020 · 7 comments

Comments

@rkagin
Copy link

rkagin commented May 4, 2020

For improved proxy support, could we add the verify and cert parameters to the requests query? I have a working copy and can do a pull request to add this functionality.

@rkagin
Copy link
Author

rkagin commented May 4, 2020

This would be done in the initialization, and the get, patch, and post functions.

@rustybrooks
Copy link
Contributor

Can you submit a PR or send me details to rbrooks@alienvault.com?

@rkagin
Copy link
Author

rkagin commented Mar 31, 2021

I made a pull request at #60.

@rustybrooks
Copy link
Contributor

It looks pretty straightforward - I'll test that it doesn't break anything but it's difficult for me to verify that it "works" if you pass values in for the new parameters. I assume that you've used it this way behind a proxy?

I'll look at it tomorrow for inclusion into the library.

@rkagin
Copy link
Author

rkagin commented Mar 31, 2021

Yes, I've used this when I set the parameters, but probably could have tested the default values. In requests, verify defaults to boolean True but also takes a local path to a CA_BUNDLE file (how I use it). The cert parameter defaults to None but also takes a local path to a client certificate.

@rustybrooks
Copy link
Contributor

OK well, like I said if it passes the "normal" tests then it's probably no worse than it is now. I'l research the defaults a bit to satisfy myself and if it passes tests then we should be good to go. Thanks for your contribution.

@rustybrooks
Copy link
Contributor

New version is out that includes your PR (I modified the defaults as suggested in the PR): 1.5.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants