-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow requests library to take verify and cert parameters #51
Comments
This would be done in the initialization, and the |
Can you submit a PR or send me details to rbrooks@alienvault.com? |
I made a pull request at #60. |
It looks pretty straightforward - I'll test that it doesn't break anything but it's difficult for me to verify that it "works" if you pass values in for the new parameters. I assume that you've used it this way behind a proxy? I'll look at it tomorrow for inclusion into the library. |
Yes, I've used this when I set the parameters, but probably could have tested the default values. In requests, |
OK well, like I said if it passes the "normal" tests then it's probably no worse than it is now. I'l research the defaults a bit to satisfy myself and if it passes tests then we should be good to go. Thanks for your contribution. |
New version is out that includes your PR (I modified the defaults as suggested in the PR): 1.5.12 |
For improved proxy support, could we add the verify and cert parameters to the requests query? I have a working copy and can do a pull request to add this functionality.
The text was updated successfully, but these errors were encountered: