Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node Discovery #38

Closed
wy opened this issue Jul 3, 2018 · 2 comments
Closed

Add Node Discovery #38

wy opened this issue Jul 3, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@wy
Copy link
Collaborator

wy commented Jul 3, 2018

At the moment, Happynodes uses the mainnet.json file from neo-mon project and looks for valid JSON-RPC, P2P or WS connections. However, there are more nodes than the ones in that file.

Since we are running a node through our neo-node sub-project, we should be able to run node discovery and update the list of known addresses and connections.

@wy wy added the enhancement New feature or request label Jul 3, 2018
@wy wy added this to the HN 1.0 - Flash milestone Jul 3, 2018
@f27d
Copy link
Collaborator

f27d commented Jul 4, 2018

Protocode:

  • Start with list of known addresses
  • Start a P2P node or use JSON-RPC to get IPs of other nodes
  • Do Reverse lookup to get hostname from IP
  • If hostname exists add it to address table (basically a ID->hostname mapping)
  • If not hostname exists, add the IP address to the address table - that's the default hostname essentially

@i25959341
Copy link
Collaborator

fixed by #64 #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants