Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record and Expose P2P Status of the nodes #7

Closed
wy opened this issue Jun 29, 2018 · 1 comment
Closed

Record and Expose P2P Status of the nodes #7

wy opened this issue Jun 29, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@wy
Copy link
Collaborator

wy commented Jun 29, 2018

One of the improvements over City of Zion's monitor is to track the P2P status of nodes. The difference between P2P and JSON-RPC is that P2P is needed for a node to receive and communicate blocks. Even if it is not a consensus node, it can play an important part in quickly communicating new blocks as they are finalized.

JSON-RPC on the other hand is needed for outside services (non-nodes) querying the node for information.

City of Zion's monitor checks for JSON-RPC but not for P2P. That means it suffers from two issues:

  1. It misses nodes that are P2P but not JSON-RPC - so they are legitimate nodes, they just can't be queried through JSON-RPC
  2. it finds nodes that are JSON-RPC but not P2P, which normally means they will have stale / old blockchain data. This is exposed in the Monitor's information, but the reason for the delay is unclear (is it because of no P2P or just some other issue)

Adding P2P is a requirement pre 1.0, and so we should treat this as a post-Hackathon clean up task.

@wy wy added this to the HN 0.9 Post-Hackathon Cleanup milestone Jun 29, 2018
@wy wy added the enhancement New feature or request label Jun 29, 2018
@wy
Copy link
Collaborator Author

wy commented Jul 1, 2018

Working - closed.

@wy wy closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants