Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker based setup #27

Closed
jeverling opened this issue Apr 14, 2020 · 8 comments
Closed

Docker based setup #27

jeverling opened this issue Apr 14, 2020 · 8 comments
Labels

Comments

@jeverling
Copy link

I don't know if it's even possible - there is the --device flag that allows a container to access devices like webcams: https://medium.com/@zwinny/docker-using-webcam-9fafb26cf1e6

But I'm not sure if it's possible for the host to access the virtual camera device if it's created inside a container.

But if possible, it would be cool to have this working as a Docker container, so you can just fire it up on a Linux based system without having to install anything into your host.

@jeverling
Copy link
Author

Seems to be possible: https://elder.dev/posts/open-source-virtual-background/

@alievk
Copy link
Owner

alievk commented Apr 15, 2020

@jeverling it would be great to have a Docker setup, indeed. However, not a critical issue at the moment.
Please let us know if you have some progress in this direction :)

@bijanmmarkes
Copy link

bijanmmarkes commented Apr 16, 2020

I think the hardest part about Dockerizing this specific application would be controlling the interactive keys, and also the aspect of having it access Zoom or Skype from within the container.

With Docker, it's best to share the devices with the container rather than adding it to the python code.
--devices with docker-compose should work efficiently, I'm giving this a go.

@alievk alievk added the docker label Apr 24, 2020
@Rohlik
Copy link

Rohlik commented May 7, 2020

I looking forward to see Docker support.

@mintmaker
Copy link
Contributor

mintmaker commented Jun 10, 2020

I am also looking forward to Docker support. It's pretty nice to not have to install things like ROS, TensorFlow and so on because you can have different versions of everything and only have to update the docker image. At the moment I am trying to hold my new Ubuntu 20.04 clean and dockerized, so it would be really neat.

I'm a bit experimenting with it at the moment with regard to the post @jeverling linked.
@bijanmmarkes Do you made progress?

Edit: Stopped experimenting right now (but may proceed later) and started install pytorch locally. But I would use docker support as soon as possible.

@mikaelhg
Copy link
Contributor

See #224.

@mintmaker
Copy link
Contributor

mintmaker commented Jun 17, 2020

#224 solves this issue, but you still have to create the virtual camera outside the container
Edit: So I guess this can be closed.

@mintmaker
Copy link
Contributor

This can be closed now. #224 has been merged and supports running everything (server and client side, and running on the machine) dockerized.

@alievk alievk closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants