Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

iOS 10: Class name taken by private frameworks #21

Closed
dzenbot opened this issue Jul 12, 2016 · 8 comments
Closed

iOS 10: Class name taken by private frameworks #21

dzenbot opened this issue Jul 12, 2016 · 8 comments

Comments

@dzenbot
Copy link

dzenbot commented Jul 12, 2016

Just like it was pointed out in #20, this library needs another name.
It causes an exception in iOS10:

-[AKSegmentedControl setSegmentedControlMode:]: unrecognized selector sent to instance...

This is the log from the debugger when launching an app using this library:

Class AKSegmentedControl is implemented in both /System/Library/PrivateFrameworks/AnnotationKit.framework/AnnotationKit (0x1b750c568) and /var/containers/Bundle/Application/A192D0FD-556C-4BB3-B910-AEAF2312DB39/... (0x100c9eb30).
One of the two will be used. Which one is undefined.
@alikaragoz
Copy link
Owner

@dzenbot will have a look during the day, maybe a Swift rewrite would be welcome.

@dzenbot
Copy link
Author

dzenbot commented Jul 12, 2016

To fix this on our end, we hardcoded the dependency and renamed its class to use 3 characters prefix to avoid the namespace collision.

Swift rewrite? Sure, but that doesn't address the inmediate problem.

@alikaragoz
Copy link
Owner

I agree, was just wondering out loud. Will provide a fix soon.

@alikaragoz
Copy link
Owner

Should be fixed, thanks for the report.

@dzenbot
Copy link
Author

dzenbot commented Jul 12, 2016

I would kepts the repository name and the podspec as AKSegmentedControl, to not break backwards compatibility for whoever is using the pod. But I guess you already pushed the new podspec to cocoapods trunk, didn't you?

@dzenbot
Copy link
Author

dzenbot commented Jul 12, 2016

Thank you for doing this so quickly btw!

@alikaragoz
Copy link
Owner

I'm afraid I did rename ALL THE THINGS 😅

@dzenbot
Copy link
Author

dzenbot commented Jul 12, 2016

😱
Well, existing users won't be able to update unless they check the new name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants