Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-class probablibity being treated as per-sample probability. #10

Open
souravraha opened this issue Jun 5, 2023 · 0 comments
Open

Comments

@souravraha
Copy link

M2m/train.py

Line 167 in 42d08a5

select_idx = torch.multinomial(p_accept, 1, replacement=True).view(-1)

@jh-jeong
In the line above p_accept is supposed to be "per-class" probability distribution. This is according to the definition of torch.multinomial. However, the implementation is treating it as a per-sample probability distribution. This is not how the subsection "Practical implementation via re-sampling" of https://arxiv.org/pdf/2004.00431.pdf describes this to be implemented. Could you shed some light on this? Thanks!

@souravraha souravraha changed the title Per-sample probablibity being treated as per-sample probability. Per-class probablibity being treated as per-sample probability. Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant