Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cronjob from delete-es-job to purge-es-job #121

Open
1 task done
d3c3mber opened this issue Jun 13, 2024 · 2 comments
Open
1 task done

Rename cronjob from delete-es-job to purge-es-job #121

d3c3mber opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@d3c3mber
Copy link
Collaborator

There's no existing/similar bug report.

  • I have searched the existing issues

Describe the bug:

Rename the cronjob as delete is not a proper word

Expected behavior:

N/A

Additional

No response

Lunettes version

No response

Kubernetes version

No response

@d3c3mber d3c3mber added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jun 13, 2024
@ponsAoki
Copy link

@d3c3mber
Nice to meet you!
I am thinking of creating a Pull Request to resolve this issue.
Can you tell me how to sign the CLA?

@d3c3mber
Copy link
Collaborator Author

d3c3mber commented Jun 17, 2024

Hi @ponsAoki, thanks very much for reaching out.
Please free feel to open an PR for this issue.

For lunettes, we don't request a CLA, we are using DCO (Developer Certificate of Origin) , contributors are required to sign off that they adhere to those requirements by adding a Signed-off-by line to the commit messages. Git has provided a -s command line option to append that automatically to your commit messages, please use it when you commit your changes.

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants