Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] get build to work with Scala 3 #1075

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Nov 4, 2023

  • Code needs small hack for spliterator - won't compile in Scala 3 otherwise - possible Scala 3 compiler bug
  • removes Scala 2.12 build option beause existing code uses Scala Factory class that was only added in Scala 2.13 - if you want to support Scala 2.12, new Scala 2.12 specific code is needed
  • updates CI to use +test which tests with all the crossScalaVersions and gets rid of setup-scala action that is deprecated in favour of setup-java - sbt build tool installs the Scala version it needs anyway so no need to pre-install Scala

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang changed the title get build to work with Scala 3 [Scala] get build to work with Scala 3 Nov 4, 2023
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks you @pjfanning.

@chaokunyang
Copy link
Collaborator

sbt +test for all scala version tests. new scala tips for me 😄

@chaokunyang chaokunyang merged commit dd541cc into apache:main Nov 4, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants